Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configure-grub just command #1206

Merged
merged 6 commits into from
May 7, 2024

Conversation

dreamyukii
Copy link
Contributor

@dreamyukii dreamyukii requested a review from castrojo as a code owner April 25, 2024 09:01
@bketelsen
Copy link
Member

i'll let others comment here too, but I think we're trying to reduce the amount of inline bash scripting in our just files and instead put an actual script on disk and call it from just.

@dreamyukii
Copy link
Contributor Author

i'll let others comment here too, but I think we're trying to reduce the amount of inline bash scripting in our just files and instead put an actual script on disk and call it from just.

done, is /usr/libexec the correct location for the script?

Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments. menu_auto_hide=2 always hides. Additionally your condition check will say the grub menu is hidden even when it's not.

I think you should have 3 states.

Always Hide, Auto Hide, and Not Hidden. Auto Hide should be the default behaviour on new installs.

Thank you for adding this, and it will be a great place to put the rest of grub logic like removing duplicate entries and regenerating grub.cfg

system_files/shared/usr/libexec/configure-grub.sh Outdated Show resolved Hide resolved
system_files/shared/usr/libexec/configure-grub.sh Outdated Show resolved Hide resolved
@m2Giles m2Giles added this pull request to the merge queue May 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 4, 2024
@dreamyukii
Copy link
Contributor Author

thank you for adding check for grub state

@m2Giles m2Giles added this pull request to the merge queue May 7, 2024
Merged via the queue into ublue-os:main with commit c330195 May 7, 2024
62 checks passed
@dreamyukii dreamyukii deleted the add-hide-grub branch August 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants