Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Go 1.19 and 1.20 #892

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Test against Go 1.19 and 1.20 #892

merged 4 commits into from
Mar 20, 2023

Conversation

cinchurge
Copy link
Collaborator

@cinchurge cinchurge commented Mar 20, 2023

Update test spec to test against the two most recent minor releases. Fixed some gofmt changes resulting from the version update.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (c6f8848) 89.18% compared to head (0e0ee08) 89.16%.

❗ Current head 0e0ee08 differs from pull request most recent head d1b638e. Consider uploading reports for the commit d1b638e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #892      +/-   ##
==========================================
- Coverage   89.18%   89.16%   -0.03%     
==========================================
  Files          43       43              
  Lines        4440     4440              
==========================================
- Hits         3960     3959       -1     
- Misses        361      363       +2     
+ Partials      119      118       -1     
Impacted Files Coverage Δ
introspection.go 95.15% <ø> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tnet/listener.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cinchurge cinchurge merged commit 0c11cc2 into dev Mar 20, 2023
@cinchurge cinchurge deleted the echung/update-tests branch March 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants