-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to allow overriding SendBufferSize pre process name prefix #772
Conversation
be7c17e
to
08279ce
Compare
Codecov Report
@@ Coverage Diff @@
## dev #772 +/- ##
==========================================
+ Coverage 88.64% 88.87% +0.23%
==========================================
Files 41 41
Lines 4140 4145 +5
==========================================
+ Hits 3670 3684 +14
+ Misses 356 349 -7
+ Partials 114 112 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but looks good overall
748c546
to
cd0585b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, when looking over the test cases, using a slice is definitely the right move, since the logic is deterministic. With a map[string]int
, if you had both abc
and abcd
, we'd have non-deterministic results since map iteration order is undefined.
Left some small cleanup comments on the test, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just nits to improve
cd0585b
to
62889a9
Compare
62889a9
to
cac7a5f
Compare
cac7a5f
to
4f86f67
Compare
This adds the ability to override SendBufferSize per process name prefix. I'm using prefix instead of regex because prefix seem to be sufficient for most usecases and is significantly faster: