Ensure Introspection endpoints are always available #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #755 +/- ##
==========================================
+ Coverage 87.62% 88.67% +1.04%
==========================================
Files 40 40
Lines 4090 4096 +6
==========================================
+ Hits 3584 3632 +48
+ Misses 389 352 -37
+ Partials 117 112 -5
Continue to review full report at Codecov.
|
AllenLuUber
reviewed
Aug 22, 2019
subchannel_test.go
Outdated
| @@ -195,8 +195,7 @@ func TestGetHandlers(t *testing.T) { | |||
| }{ | |||
| { | |||
| serviceName: ch.ServiceName(), | |||
| // Default service name comes with extra introspection methods. | |||
| wantMethods: []string{"_gometa_introspect", "_gometa_runtime", "method1", "method2"}, | |||
| wantMethods: []string{"method1", "method2"}, | |||
There was a problem hiding this comment.
To confirm this removal: before we registered both introspection and actual procedure together. Now we don't and those introspection are not visible anymore during actual handling.
There was a problem hiding this comment.
Yep exactly. They're no longer just "user-level" methods, but internal methods that are always registered at a higher layer, so they don't show up here anymore.
AllenLuUber
approved these changes
Aug 22, 2019
Currently, introspection endpoints only work if the service doesn't use
SetHandler to completely take over the procedure->handler mapping, and
if the caller uses either the service name of the channel or "tchannel"
to hit the introspection endpoints.
Instead, let's always handle introspection first regardless of the
service name.
The test added panics without this change,
```
=== RUN TestIntrospectionNotBlocked
=== RUN TestIntrospectionNotBlocked/no_relay
panic: should not be called
goroutine 20 [running]:
github.com/uber/tchannel-go_test.TestIntrospectionNotBlocked.func1.1(0xa498c0,
0xc000152070, 0xc0001da000)
/home/prashant/go/src/github.com/uber/tchannel-go/introspection_test.go:125
```
prashantv
force-pushed
the
always_add_introspect
branch
from
7996f09 to
6a60a55
Compare
abhinav
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, introspection endpoints only work if the service doesn't use
SetHandler to completely take over the procedure->handler mapping, and
if the caller uses either the service name of the channel or "tchannel"
to hit the introspection endpoints.
Instead, let's always handle introspection first for the "tchannel" service. This
cannot be overridden, and no other service names work for introspection.
The test added panics without this change,