idle sweeper: Don't close connections with pending calls #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
force-pushed
the
idle_with_pending
branch
from
a3357f5 to
6178642
Compare
As documented in #701, we currently attempt closing connections even if they have pending calls. This can cause issues if the calls is stuck as the connection enters start-close, so it'll reject new incoming calls, but it doesn't close, so the remote side keeps sending calls over the same connection. Fixes #701.
prashantv
force-pushed
the
idle_with_pending
branch
from
6178642 to
595bdfc
Compare
Codecov Report
@@ Coverage Diff @@
## dev #712 +/- ##
==========================================
+ Coverage 87.39% 87.73% +0.33%
==========================================
Files 40 40
Lines 4047 4052 +5
==========================================
+ Hits 3537 3555 +18
+ Misses 386 377 -9
+ Partials 124 120 -4
Continue to review full report at Codecov.
|
witriew
reviewed
Jul 30, 2018
idle_sweep_test.go
Outdated
|
|
||
| listener := newPeerStatusListener() | ||
| serverOpts := testutils.NewOpts(). | ||
| AddLogFilter("Skip closing idle Connection as it has pending calls.", 1). |
There was a problem hiding this comment.
Was looking over this and I initially thought that it would check and verify for this log message. It'd probably be great if we could do that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #701, we currently attempt closing connections even
if they have pending calls. This can cause issues if the calls is stuck
as the connection enters start-close, so it'll reject new incoming
calls, but it doesn't close, so the remote side keeps sending calls over
the same connection.
Fixes #701.