Pass context to Thrift post response callback

[robskillington]

cc @prashantv

[prashantv]

nit: Equal should have expected argument before the value it's testing, so this should be,

assert.Equal(t, value, ctx.Value(key))

[prashantv]

I don't think this test is testing what you're intending for it to test. So right now, you're using the contextFn to create the context that's passed in to the to the test function. So you're basically testing that your test logic creates the context using the function you specified, and that it has the value you set.

What you actually want to test is: if you call SetContextFn (https://godoc.org/github.com/uber/tchannel-go/thrift#Server.SetContextFn) to override the context creation to include an extra value, the context you receive inside of the cb has that same value.

You probably want your contextFn to be used to call SetContextFn on a thrift.Server right after creating it.

[robskillington]

Yeah I just wanted to test its the same context being threaded through, don't really mind about where exactly it's created from.

[prashantv]

The issue is that reqCtx is not being tested -- you could pass nil as a parameter to the context in the Thrift code, and the test would still pass.

The test should make sure that reqCtx is the same context that is returned from the context creation function set by SetContextFn

[prashantv]

The library change looks good, but the test isn't testing the right behaviour.

[robskillington]

Updated @prashantv with changes, was a lot easier to test with SetContextFn that I originally had believed.

[prashantv]

lgtm, thanks @robskillington