Add fallback to m.uber for Ride Request Deeplinks #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyvsmith
reviewed
Feb 2, 2018
| private let fallbackType: DeeplinkFallbackType | ||
|
|
||
| @objc public convenience init(rideParameters: RideParameters = RideParametersBuilder().build()) { | ||
| self.init(rideParameters: rideParameters, fallbackType: DeeplinkFallbackType.mobileWeb) |
There was a problem hiding this comment.
The default should probably be app store, then mobile Web.
There was a problem hiding this comment.
I feel like we should encourage more muber usage, but it's up to the team!
edjiang
added a commit
that referenced
this pull request
Feb 6, 2018
* Add fallback to muber for Ride Request Deeplinks * Remove erroneous print statement * Make App Store Deeplink default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows deeplinks to specify a fallback if the original deeplink doesn't open properly.
We add a
fallbackURLs: [URL]property to theDeeplinkingprotocol. TheBaseDeeplinkimplements it and automatically adds theUber-enterpriseandUber-nightlyschemes if the original scheme isuber, to make beta testing easier.The
DeeplinkManageris modified so that it uses the fallbacks if opening a deeplink is not successful.The
RequestDeeplinkandDeeplinkRequestingBehaviortake an additionalDeeplinkFallbackTypeenum in the initializer which defaults to.mobileWeb. Otherwise, it can fall back to.appStoreor.none.