-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ride Status not available with ObjC ? #94
Comments
You are correct, good find. This is because Objective-C does not support an optional Enum (which is how rideStatus is defined). The fix will be not having rideStatus optional and instead giving it a default value. If you like, since you found this, you can put up a PR and I would be happy to review it |
Can you please explain a little bit more where to do the modification ? can we add this status property in the UBSDKRide class ? How this property will be updated by current API ? Tx for helping |
The status property exists, it just is not currently being exposed in the Objective-C interface. In order to expose it, it needs to be something that can be represented in Objective-C. So, what I think should work is a slight modification in Need to change: /// The status of the Request indicating state.
public private(set) var status: RideStatus? to: /// The status of the Request indicating state.
public private(set) var status: RideStatus = .Unknown and make adjustments wherever |
Fixed in v0.5.3 |
UBSDKRide does not expose ride Status.
How to get the ride status after a call to fetchRideDetails ?
The text was updated successfully, but these errors were encountered: