This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Fix docker image file modes #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank for being patient on this. If you are still interested in this PR, can you rebase dev and update? |
Before this, these files had file mode 0640. This meant that running the image with e.g. `docker run -u $(id -u):$(id -g) uber/prototool ...` would typically fail, since the files would be inaccessible.
Fixes build of docker image.
jensl
force-pushed
the
fix-docker-image-file-modes
branch
from
d11fb0b to
5f1fae0
Compare
|
PR rebased onto current dev. |
|
Can you run |
smaye81
reviewed
Mar 10, 2020
| check_env GRPC_GATEWAY_VERSION 1.8.5 | ||
| check_env GRPC_WEB_VERSION 1.0.4 | ||
| check_env PROTOBUF_VERSION 3.6.1 | ||
| check_env PROTOBUF_VERSION 3.10.1 |
There was a problem hiding this comment.
Can you bump this to 3.11.2
| check_env TWIRP_VERSION 5.7.0 | ||
| check_env YARPC_VERSION 1.37.3 | ||
| check_env PROTOTOOL_PROTOC_BIN_PATH /usr/bin/protoc | ||
| check_env PROTOTOOL_PROTOC_WKT_PATH /usr/include | ||
| check_command_output "libprotoc 3.6.1" protoc --version | ||
| check_command_output "libprotoc 3.10.1" protoc --version |
There was a problem hiding this comment.
This will probably also need changed
|
FYI, if you rebase, you should get all the latest dependency updates from the |
|
Ping on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make files in
/usr/include/google/protobufworld readable in the docker image.Also update gRPC and Protobuf versions that are installed, to fix the docker image build.