Final touchups for 0.5.0 release #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puts the buildscript/repo config back in the top level (I think they were accidentally moved) Switches to file base api for checkstyle destination, previous was deprecated
This gives the README some much-needed love. * Update for the new as() API * Consolidate duplicate plugin sections (wat) * Document public AutoDisposing observers and their delegateObserver() methods * Some various other fine tunings
This is not going to be changed in the future, as it's useful for subscribeWith scenarios too and we don't need to unnecessarily tie it down
Closed
|
Did an over the shoulder review, merging since it's not functional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few housecleaning changes:
delegateObserver()APIs to stable since we'll keep these. This ensures they're compatible withsubscribeWithin the future, and we can keep the library flexible.