Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for controlling whether or not to fill in stacktraces #124

Merged
merged 2 commits into from
Oct 30, 2017

Conversation

ZacSweers
Copy link
Collaborator

Resolves #117

This implements support for controlling whether or not OutsideLifecycleExceptions fill in their stacktraces. This is a potentially expensive operation that is often used just for signaling, so we can save a little perf here.

This implements support for controlling whether or not `OutsideLifecycleException`s fill in their stacktraces. This is a potentially expensive operation that is often used just for signaling, so we can save a little perf here.
@tonycosentini
Copy link
Contributor

Is it possible to add more details about what the specific performance improvements are?

Also +1 to Leland's comment about including example stacktraces to demonstrate the differences.

@ZacSweers
Copy link
Collaborator Author

Details beyond

This is a potentially expensive operation that is often used just for signaling, so we can save a little perf here.

?

I’ll add an example, but bear in mind the point is that there is no trace, just the exception name and message. In a conventional “stacktrace”, the difference is that you effictively only get the first line here

@tonycosentini
Copy link
Contributor

What is expensive? Just creating the stacktrace itself? Whatever it is, just mentioning it might be useful.

@ZacSweers
Copy link
Collaborator Author

Yes, fillInStacktrace() is (this is detailed in the linked issue as well)

@tonycosentini
Copy link
Contributor

Is it worth adding the same details to the javadoc?

@ZacSweers
Copy link
Collaborator Author

Beyond what's already there?

Disabling them, if you don't care about the stacktraces, can result in some minor performance improvements.

@tonycosentini
Copy link
Contributor

Yes, beyond what's already there.

@ZacSweers
Copy link
Collaborator Author

(talked and the javadoc is fine as-is)

@ZacSweers ZacSweers merged commit 5b35ba8 into master Oct 30, 2017
@ZacSweers ZacSweers deleted the z/fillInStacktrace branch October 30, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants