You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think these checks are needed, and in fact we may miss issues (e.g., if both types are array types and inside there are nested type arguments with mismatched nullability). We should remove these checks and add corresponding tests.
The text was updated successfully, but these errors were encountered:
Removing unnecessary checks performed for ClassType in
GenericChecks.java in reference to issue #861. Added some null checks
since some of the checks for ClassType were also indirectly checking for
nullability and hence removing them entirely cause the test rawTypes to
crash.
Fixes#861
---------
Co-authored-by: Manu Sridharan <[email protected]>
There are various places in
GenericsChecks
that we only perform checks forClassType
s, e.g.:NullAway/nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
Line 304 in 4b6e672
NullAway/nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
Lines 336 to 338 in 4b6e672
I don't think these checks are needed, and in fact we may miss issues (e.g., if both types are array types and inside there are nested type arguments with mismatched nullability). We should remove these checks and add corresponding tests.
The text was updated successfully, but these errors were encountered: