Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix which JDKs are installed on CI #835

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

msridhar
Copy link
Collaborator

We need some version of JDK 21 installed now (after #834) for the snapshot job to succeed, even though it's not used. Take the opportunity to simplify other usage of setup-java.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d04828a) 86.75% compared to head (47d8f5f) 86.75%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #835   +/-   ##
=========================================
  Coverage     86.75%   86.75%           
  Complexity     1870     1870           
=========================================
  Files            74       74           
  Lines          6178     6178           
  Branches       1202     1202           
=========================================
  Hits           5360     5360           
  Misses          407      407           
  Partials        411      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar enabled auto-merge (squash) September 28, 2023 17:00
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit 7e36bb0 into uber:master Sep 28, 2023
9 checks passed
@msridhar msridhar deleted the fix-ci-jdks branch September 28, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants