Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-determinism in test coverage of AccessPath #828

Closed
msridhar opened this issue Sep 4, 2023 · 0 comments · Fixed by #838
Closed

Fix non-determinism in test coverage of AccessPath #828

msridhar opened this issue Sep 4, 2023 · 0 comments · Fixed by #838

Comments

@msridhar
Copy link
Collaborator

msridhar commented Sep 4, 2023

Sometimes code coverage reports a reduction in coverage for the AccessPath class even when the PR changes nothing related to that code. Here is an example. I suspect some kind of non-determinism on our code or tests; we should try to track this down.
@msridhar msridhar mentioned this issue Sep 17, 2023
Merged
@msridhar msridhar mentioned this issue Sep 29, 2023
Merged
msridhar added a commit that referenced this issue Sep 29, 2023
@msridhar
Ignore code coverage for method executed non-deterministically in tes…
91374c3 
…ts (#838)

Fixes #828 (hopefully)

There is some non-determinism in whether
`com.uber.nullaway.dataflow.AccessPath.IteratorContentsKey#equals` runs
or not during tests (see the code comment). The non-determinism will be
hard for us to fix, so instead, add an annotation that tells JaCoCo to
ignore coverage of this method (which is low risk as it's an `equals()`
method that I don't expect will change).
@msridhar msridhar mentioned this issue Oct 8, 2023
Merged
msridhar added a commit that referenced this issue Oct 8, 2023
@msridhar
Ignore another method for code coverage (#844)
424cf63 
Another fix related to #828 (see also #838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore code coverage for method executed non-deterministically in tests msridhar/NullAway
1 participant
@msridhar