Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASM-related hack in build config #824

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 3, 2023

I'm guessing this was necessary for building on Java 8, but now everything works without it.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed4d0ae) 86.81% compared to head (27b9280) 86.81%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #824   +/-   ##
=========================================
  Coverage     86.81%   86.81%           
  Complexity     1863     1863           
=========================================
  Files            74       74           
  Lines          6165     6165           
  Branches       1197     1197           
=========================================
  Hits           5352     5352           
  Misses          405      405           
  Partials        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review September 3, 2023 14:22
@msridhar msridhar changed the title Try removing ASM hack Remove ASM-related hack in build config Sep 3, 2023
@msridhar msridhar requested a review from lazaroclapp September 3, 2023 14:23
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. If the build ever fails we can always re-add it, but it seems all jobs are passing now!

@msridhar msridhar merged commit a7b097a into uber:master Sep 5, 2023
9 checks passed
@msridhar msridhar deleted the remove-asm-hack branch September 5, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants