-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo scope provider for Activity #36
Comments
I think we should provide some examples of how to hook one up, but I don't think we should ship something first party. Especially with support library variants out there, kind of makes a mess and most people just implement it in their own base classes I think. Can revisit if Android APIs improve in the future for external observation. |
Activities have ActivityLifecycleCallbacks. |
True, but we can't query the current state of the activity for lifecycle resolution :/. Most we could do would basically be to dispose on destroy, but wouldn't be able to tell if we're already after the lifecycle |
Do you need to query the current state of the activity? You should get all edges of the state machine in the callbacks instance, and infer state from that. Unless there are edge cases I'm not thinking of. |
Say you subscribe after onDestroy, how would you know since no callbacks would ever fire? |
I think some code in Glide do the similar things. |
You can get callbacks, but you can't query the current state right? |
No description provided.
The text was updated successfully, but these errors were encountered: