Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few misc bits #116

Merged
merged 3 commits into from
Oct 21, 2017
Merged

A few misc bits #116

merged 3 commits into from
Oct 21, 2017

Conversation

ZacSweers
Copy link
Collaborator

Update Kotlin and add some missing bits from the structured android components PR

@ZacSweers ZacSweers added this to the 0.4.0 milestone Oct 21, 2017
@ZacSweers ZacSweers self-assigned this Oct 21, 2017
@ZacSweers ZacSweers requested review from jbarr21, kageiit and 0legg and removed request for jbarr21 October 21, 2017 04:37
jbarr21
jbarr21 reviewed Oct 21, 2017
View reviewed changes
Copy link
Collaborator

@jbarr21 jbarr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbarr21 jbarr21 self-requested a review October 21, 2017 23:24
jbarr21
jbarr21 approved these changes Oct 21, 2017
View reviewed changes
Copy link
Collaborator

@jbarr21 jbarr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber_stamp:

@ZacSweers ZacSweers merged commit 0e543ef into master Oct 21, 2017
@ZacSweers ZacSweers deleted the z/missingbits branch October 21, 2017 23:25
@ZacSweers ZacSweers mentioned this pull request Oct 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbarr21 jbarr21 jbarr21 approved these changes

@kageiit kageiit Awaiting requested review from kageiit

@0legg 0legg Awaiting requested review from 0legg

Assignees

@ZacSweers ZacSweers

Labels
Android Kotlin
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacSweers @jbarr21