Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing synthetic accessors #102

Closed
bangarharshit opened this issue Oct 8, 2017 · 3 comments
Closed

Removing synthetic accessors #102

bangarharshit opened this issue Oct 8, 2017 · 3 comments

Comments

@bangarharshit
Copy link
Contributor

There is around 27 synthetic accessors method (most of which are in tests). RecordingObserver, AutoDisposingSubscriberImpl (and similar classes) has around 12 methods. Maybe convert them to package protected to reduce dex count by 12.
@ZacSweers
Copy link
Collaborator

want to send a proposal PR? Can't promise all of them for API reasons but would want to see what the scope is.

@bangarharshit bangarharshit mentioned this issue Oct 8, 2017
Merged
@bangarharshit
Copy link
Contributor Author

Created a PR. Also verified that proguard is not inling the methods.

@bangarharshit
Copy link
Contributor Author

Closing since it is merged. All the other synthetic accessors are in tests and which can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZacSweers @bangarharshit