Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues in GA experiment #42

Open
adityauser opened this issue Jun 20, 2020 · 0 comments
Open

Minor issues in GA experiment #42

adityauser opened this issue Jun 20, 2020 · 0 comments

Comments

@adityauser
Copy link

Issue 1:
At line:

eval_rews, eval_length = policy.rollout(env) # eval rollouts don't obey task_data.timestep_limit

The rollout function returns 3 objects, due to which we getting an error:
ValueError: too many values to unpack (expected 2)
It could be solved by replacing line 230 with:
eval_rews, eval_length, _ = policy.rollout(env)
Issue 2:
At line:
lengths_n2 = np.array([r.lengths_n2 for r in curr_task_results])

It should be lengths_n2 = np.concatenate([r.lengths_n2 for r in curr_task_results]) very much similar to
lengths_n2 = np.concatenate([r.lengths_n2 for r in curr_task_results])

Otherwise lengths_n2.mean() and lengths_n2.sum() will have multiple dimension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant