Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate elision #9

Open
abhinav opened this issue Apr 21, 2021 · 0 comments
Open

More accurate elision #9

abhinav opened this issue Apr 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@abhinav
Copy link
Contributor

abhinav commented Apr 21, 2021

Elision correlation between the - and + sections of a patch is very naive right now. It matches based on positions of the ellipses in the patch, so it can easily get things wrong.

We should consider a more sophisticated elision matching implementation; perhaps by diffing the - and + sections.

Alternatively, or in addition to that, we may want to support named elisions or equivalent for cases where even best-effort elision won't behave correctly.

@abhinav abhinav added the enhancement New feature or request label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant