Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global variables expose extension to possible manipulation #8

Closed
ppseprus opened this issue May 5, 2017 · 1 comment
Closed

Global variables expose extension to possible manipulation #8

ppseprus opened this issue May 5, 2017 · 1 comment

Comments

@ppseprus
Copy link
Contributor

ppseprus commented May 5, 2017 •
edited
Loading

The variables st_type, st_freq, st_q and st_gain are injected to each tab as global variables.
Any extension or the website itself could change the values of these variables, therefore, change the settings of the filter.
@ppseprus
Copy link
Contributor Author

ppseprus commented May 7, 2017

NOTE: This issue is already addressed in PR #10.

@mavroudisv mavroudisv mentioned this issue May 8, 2017
Open
@ppseprus ppseprus closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppseprus