Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the BASE_FEATURE define #290

Closed
uazo opened this issue Jul 14, 2023 · 2 comments
Closed

Modify the BASE_FEATURE define #290

uazo opened this issue Jul 14, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@uazo
Copy link
Owner

uazo commented Jul 14, 2023

it happens that sometimes wiggle makes unexpected changes, for example:

@@ -1525,8 +1525,8 @@ BASE_FEATURE(kUseWebAppDBInsteadOfExternalPrefs,
              base::FEATURE_ENABLED_BY_DEFAULT);
 
 BASE_FEATURE(kWebAuthFlowInBrowserTab,
-             "WebAuthFlowInBrowserTab",
-             base::FeatureState::FEATURE_DISABLED_BY_DEFAULT);
+             "WebAuthFlowInBrowserTab",                         // disable by default
+             base::FeatureState::FEATURE_DISABLED_BY_DEFAULT);  // in bromite
 const base::FeatureParam<WebAuthFlowInBrowserTabMode>::Option
     web_auth_flow_modes[] = {

becomes

@@ -1560,8 +1560,8 @@ BASE_FEATURE(kUseWebAppDBInsteadOfExternalPrefs,
              base::FEATURE_ENABLED_BY_DEFAULT);
 
 BASE_FEATURE(kWebAuthFlowInBrowserTab,
-             "WebAuthFlowInBrowserTab",
-             base::FeatureState::FEATURE_ENABLED_BY_DEFAULT);
+             "WebAuthFlowInBrowserTab",                         // disable by default
+             base::FeatureState::FEATURE_ENABLED_BY_DEFAULT);  // in bromite
 const base::FeatureParam<WebAuthFlowInBrowserTabMode>::Option
     web_auth_flow_modes[] = {

notice disabled to enabled

To solve this I should create a BASE_FEATURE_ALWAYS_DISABLED so that it is not confused

seen in #286

@uazo uazo added bug Something isn't working enhancement New feature or request labels Jul 14, 2023
@uazo
Copy link
Owner Author

uazo commented Aug 10, 2023

To solve this I should create a BASE_FEATURE_ALWAYS_DISABLED so that it is not confused

wouldn't work anyway.
the problem is in wiggle, which would automatically modify that too in that case.
assess whether it is possible to set it when loading flags

@uazo
Copy link
Owner Author

uazo commented Oct 21, 2023

uazo/cromite#403

@uazo uazo closed this as completed Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant