Ice liq new splitting #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve an issue with ice being assigned negative values, or values greater than the original ice quantity being split.
Also adds some comments and cleanup details.
|
These are single-cell plots from a couple regions. The cell 345 is not a comparison, as baseline cannot complete a run there. Toolik 6 Basins Cell 345 |
|
Hélène and I reviewed the plots, and while there are some quirks they are either also in the master branch results or appear to be due to incomplete parameterizations rather than the changes implemented in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the ice and liquid redistribution on layer split
to avoid an error that occurs when the frozen fractions of
the two new layers are very close to each other.