Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Remove phantom js runner from Karma #653

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Remove phantom js runner from Karma #653

merged 1 commit into from
Jun 30, 2017

Conversation

ChristianMurphy
Copy link
Contributor

Chrome is now primary test runner.
Also https://www.bithound.io/github/ChristianMurphy/angularjs-portal/master/dependencies/npm/phantomjs#security-advisories


Contributor License Agreement adherence:

@davidmsibley
Copy link
Contributor

What's the real security risk with phantomjs? Considering it is only used within the testing, and all code that calls it is our own, I'd think those risks are mitigated.

That said, I have no opinion over which launcher we use.

@apetro
Copy link
Contributor

apetro commented Jun 30, 2017

Hurray for removing dependencies we don't need. Let's worry about the realities of phantomjs security if and when there's a need for it to come back in as a dependency. :)

@ChristianMurphy
Copy link
Contributor Author

ChristianMurphy commented Jun 30, 2017

@davidmsibley uPortal-Attic/uportal-app-framework#462 gives more in-depth explanation for the switch. 📜
For the security side, its less that I see it as a risk, and more that I'm tired of seeing angularjs-portal unnecessarily flagged in the dependency security reports. 😜

@ChristianMurphy ChristianMurphy merged commit 7caa631 into uPortal-Attic:master Jun 30, 2017
@ChristianMurphy ChristianMurphy deleted the NOJIRA-remove-phantom-and-phantom-launcher branch June 30, 2017 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants