-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer when using with Socket.io #705
Comments
You can see the error is in |
@tahayk They are doing this wrong on this line https://github.com/socketio/engine.io/blob/a463d268ed90064e7863679bda423951de108c36/lib/transports-uws/polling.ts#L158 They are trying to concat Buffer views of arrayBuffers that are already gone, need to make copy |
Buffer.from(arrayBuffer).copy(allocatedBuffer, offset) |
That's kind of interesting that they've actually built polling on uws http and are using the pub sub features. That means we've won, they have adopted our features and our API. Compare this with 2016 when we adopted their interfaces and acted like a drop in module for their shitty API. That's a milestone since the NPM shitfest days. |
I added PR to fix Socket.io issue here socketio/engine.io#642 as described here socketio/socket.io#4281 (comment) |
@tahayk they just merged PR and released new version, that should be fixed for you |
@e3dio thank you very much for your help |
Hey
I'm trying to use uWebSockets with Socket.io,
but I keep getting this error, and I noticed that it only happens when I use Safari:
Here is the example I used:
server.js:
demo.html
Any idea about this issue ?
Thanks.
The text was updated successfully, but these errors were encountered: