Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock Origin Lite default filter breaks pushbullet extension #8

Closed
8 tasks done
rhee876527 opened this issue Oct 12, 2022 · 15 comments
Closed
8 tasks done

uBlock Origin Lite default filter breaks pushbullet extension #8

rhee876527 opened this issue Oct 12, 2022 · 15 comments

Comments

@rhee876527
Copy link

rhee876527 commented Oct 12, 2022

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For any support, questions or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Pushbullet breaks when Default filter is selected

Ads, Trackers, Miners, And More

...................................

P.S I have tested original uBlock Origin extension and it does not exhibit this behavior.

A specific URL where the issue occurs.

https://www.pushbullet.com

Steps to Reproduce

  1. Install pushbullet extension and login with account
  2. Install ublock lite extension
  3. Select default filter list if not selected
  4. Test sending/receiving a push message

Expected behavior

Pushbullet extension to work as normal

Actual behavior

  1. Sending message/link fails
  2. Extension doesn't receive messages from other pb clients

uBO version

uBlock Origin Lite 0.1.22.9305

Browser name and version

Ungoogled chromium 106.0.5249.91

Operating System and version

Arch Linux with kernel 6.0.0

@mapx- mapx- transferred this issue from uBlockOrigin/uBlock-issues Oct 12, 2022
@mapx-
Copy link

mapx- commented Oct 12, 2022

update to the last version uBlock Origin Lite 0.1.22.10106 and test if still happens

@rhee876527
Copy link
Author

update to the last version uBlock Origin Lite 0.1.22.10106 and test if still happens

Just updated. No dice.

@mapx-
Copy link

mapx- commented Oct 12, 2022

Inspect on pb extension => in console issues on static.pushbullet.com ...

EasyPrivacy has a filter => ||pushbullet.com^$third-party

I downloaded uBOL to install it manually as unpacked extension
https://github.com/gorhill/uBlock/releases/tag/uBOLite_0.1.22.10106

Then I edited default.json file removing "pushbullet.com", , I updated uBOL (extensions panel) to get the new default.json version and this way seems the pb extension works correctly.

Why uBO has no issues with the same filter ?

@gorhill

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

Is anything blocked by uBO for pushbullet.com? If not, what is the context of network requests to pushbullet.com?

@mapx-
Copy link

mapx- commented Oct 12, 2022

in uBO I get nothing in the extension console

in uBOL

d3d92f6609934655e5b8c4d79cef05d1bfd6caa1f0bdf89cbf78118fb46c9c6a:1          GET https://static.pushbullet.com/google-user/d3d92f6609934655e5b8c4d79cef05d1bfd6caa1f0bdf89cbf78118fb46c9c6a net::ERR_BLOCKED_BY_CLIENT
Image (async)
createStreamRow @ panel-messaging.js:137
(anonymous) @ panel-messaging-push.js:314
setUpPushStreams @ panel-messaging-push.js:287
pushesLocalsChangedListener @ panel-messaging-push.js:68
onFocusChanged @ panel-messaging.js:12
(anonymous) @ page.js:8

ec9e31da85bd6db35f40f1e23833e05b7a8fa4942ff372c054efc21739f534fb:1          GET https://static.pushbullet.com/google-user/ec9e31da85bd6db35f40f1e23833e05b7a8fa4942ff372c054efc21739f534fb net::ERR_BLOCKED_BY_CLIENT
Image (async)
(anonymous) @ chat-push.js:431
(anonymous) @ chat-push.js:231
renderPushChunks @ chat-push.js:226
drawPushChat @ chat-push.js:43
updatePushChat @ chat-push.js:5
pushesLocalsChangedListener @ panel-messaging-push.js:77
onFocusChanged @ panel-messaging.js:12
(anonymous) @ page.js:8

@mapx-
Copy link

mapx- commented Oct 12, 2022

the network tab:

image

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

With uBOL, what is the initiator in the network tab?

With uBO, what is the context reported in the logger for these not-blocked network requests?

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

Inspect on pb extension

Ok I understand. With MV3 API, uBOL is allowed to interfere with another extension's network requests, which is quite unexpected and it does appear to be a bug in the MV3 API. In MV2, extensions are not allowed to read/modify network requests made by other extensions.

@mapx-
Copy link

mapx- commented Oct 12, 2022

In this case is there a special context (identifying an extension) just to understand if it's impacting another extension ?

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

The initiator is the chrome-extension:// protocol, so I wonder if I can exclude uBOL using an allowAll rule, I will have to experiment.

@mapx-
Copy link

mapx- commented Oct 12, 2022

I've notified Simeon Vincent on slack

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

I can't seem to be able to fix this with a rule, so we will need a ubol-filters.txtlist to create exceptions for these cases for the time being.

@gorhill
Copy link
Member

gorhill commented Oct 12, 2022

Ok I can confirm the badfiltering fixes the issue. I didn't create a Pushbullet account, but I could see an analytic-related network request being blocked, and it's no longer blocked with the badfilter filter. Now I will have to wait for a currently pending review to clear before I can push a new version with the fix.

@mapx- mapx- reopened this Oct 16, 2022
@gorhill
Copy link
Member

gorhill commented Oct 22, 2022

Why reopen?

@gorhill gorhill closed this as completed Nov 6, 2022
@rhee876527
Copy link
Author

Same anomaly has cropped up again with the newly added blocklists, namely

EasyList – Annoyances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants