I want to contribute coin-miner filter list to uBlock please

[PeterDaveHello]

Hi there,

I've noticed that pull request is not welcome as the main project CONTRIBUTING mentions, just want to make sure if it possible or how to contribute to the filter list, as I see this uAssets repo but I didn't see the filter list in this repo.

I've make some changes in my own forked uBlock repo:

Commits:

• PeterDaveHello/uBlock@c8c133a
  PeterDaveHello/uBlock@4737a3d

Branch:

• https://github.com/PeterDaveHello/uBlock/tree/block-coin-miner

Which would add "NoCoin adblock list"(https://github.com/hoshsadiq/adblock-nocoin-list) in the filter list, would you please let me know how can I do it or I just can't?

Many thanks!

[okiehsch]

If you think uBlock should add a filter list, you can open an issue at https://github.com/gorhill/uBlock.
It has been done before. gorhill/uBlock#3089.

I see no reason to add https://github.com/hoshsadiq/adblock-nocoin-list, because at a quick glance all entries except ||api.inwemo.com^$third-party are already included in https://github.com/uBlockOrigin/uAssets/blob/master/filters/resource-abuse.txt, which is enabled by default in uBO.
inwemo.com has a mandatory opt-in as far as I can see, so unless someone can provide an example of it starting mining without user interaction I don't think it should be added to resource-abuse.txt, as I already stated in another case.

[PeterDaveHello]

@okiehsch thanks for your prompt reply, I'll take a look at the resource you gave me 😄