Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for deleting chat messages, use HTTP endpoints for mute test #665

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Add tests for deleting chat messages, use HTTP endpoints for mute test #665

merged 6 commits into from
Nov 25, 2024

Conversation

goto-bus-stop
Copy link
Member

Instead of mocking isMuted

Increases test coverage.
The retryFor helper makes this run a bit faster typically.

@goto-bus-stop goto-bus-stop changed the title Test chat mute Use mute endpoint in chat test Nov 25, 2024
@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Coverage Status

coverage: 81.647% (+0.7%) from 80.964%
when pulling 7f426f1 on test-chat-mute
into b882eb2 on default.

@goto-bus-stop goto-bus-stop marked this pull request as draft November 25, 2024 14:04
@goto-bus-stop goto-bus-stop changed the title Use mute endpoint in chat test Add tests for deleting chat messages, use HTTP endpoints for mute test Nov 25, 2024
@goto-bus-stop goto-bus-stop marked this pull request as ready for review November 25, 2024 17:22
@goto-bus-stop goto-bus-stop merged commit 4ec71f3 into default Nov 25, 2024
12 checks passed
@goto-bus-stop goto-bus-stop deleted the test-chat-mute branch November 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @coveralls