Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] when will the non-blocking feature in dev branch make it to master #858

Open
3 of 10 tasks
amm009uk opened this issue Mar 24, 2019 · 1 comment
Open
3 of 10 tasks

Comments

@amm009uk
Copy link

sonoff Basic
WiFimanager Branch/Release:

  • Master
  • Development

Esp8266/Esp32:

  • ESP8266
  • ESP32

Hardware: ESP-12e, esp01, esp25

  • ESP01
  • ESP12 E/F/S (nodemcu, wemos, feather)
  • Other

ESP Core Version: 2.4.0, staging

  • 2.3.0
  • 2.4.0
  • staging (master/dev)

Description

When will non-blocking feature in development branch reach main branch?

Problem description

I am using the non-blocking feature in development branch and it appears to be working fine on sonoff basic. When will this feature reach the main branch?
I am asking because the compiled code is larger when using development branch (after removing unsupported features).

void setup() {
WiFiManager wifiManager;
wifiManager.setConfigPortalBlocking(false);

if(!wifiManager.autoConnect(deviceID)) {
debugln(F("WiFi Connected"));
}
}

void loop() {
...
wifiManager.process();
...
}

@tablatronix
Copy link
Collaborator

Ill release a beta soon when I know people have tested it. I think its ready and tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants