Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSL styles not including annotations #91

Closed
K3das opened this issue Nov 28, 2023 · 2 comments
Closed

CSL styles not including annotations #91

K3das opened this issue Nov 28, 2023 · 2 comments

Comments

@K3das
Copy link

K3das commented Nov 28, 2023

Trying the following entry with chicago-annotated-bibliography.csl results in no annotation being rendered, whereas the CSL editor renders this annotation.

@article{kameny_ladder,
	title = {Does Research Into Homosexuality Matter?},
	volume = {9},
	url = {https://digitalassets.lib.berkeley.edu/sfbagals/The_Ladder/1965_Ladder_Vol09_No08_May.pdf},
	pages = {14--21},
	number = {8},
	journaltitle = {The Ladder},
	author = {Kameny, Franklin},
	date = {1965-05},
	note = {Annotation test string},
}

Here's an example project for reference

The Citation Styles Visual Editor renders an annotation like so:
image

Yet Typst has no annotation:
image

@DerDrodt
Copy link
Contributor

DerDrodt commented Dec 4, 2023

The problem is that the translation from BibLaTeX to hayagriva throws out the note. When converting a biblatex::Entry to a hayagriva::Entry, it does the following:

if let Some(note) = map_res(entry.how_published())?.map(Into::into) {
    if let Some(parent) = book(&mut item, parent) {
        parent.set_note(note);
    } else {
        item.set_note(note);
    }
}

At no other point is note set.

The question therefore is, how to handle "how published": Give it its own hayagriva field or append it to the note?

@EpicEricEE
Copy link

I believe this should be fixed with #220. It now renders as

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants