Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-notifier to resolve got vulnerability CVE-2022-33987 #1343

Closed
illandril opened this issue Jul 5, 2022 · 3 comments · Fixed by #1365
Closed

Update update-notifier to resolve got vulnerability CVE-2022-33987 #1343

illandril opened this issue Jul 5, 2022 · 3 comments · Fixed by #1365

Comments

@illandril
Copy link
Contributor

json-server depends on a vulnerable version of got (by way of update-notifier -> latest-version -> package-json -> got).

Updating update-notifier to 6.0.2 would resolve this (but I'm not sure how much else would need to change to allow that upgrade).

@riker09
Copy link

riker09 commented Jul 14, 2022

Looks like this is going to be a not so easy task. I tried to create a PR for this but then I discovered why the update of the npm package update-notifier from 5.x to 6.x is considered a breaking change. That package is all ESM now (see https://github.com/yeoman/update-notifier/releases/tag/v6.0.0).

I guess I could take a shot at converting json-server to use the new ESM import / from syntax.


Source: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

@riker09
Copy link

riker09 commented Aug 16, 2022

Unfortunately it is that time of the year (you know, where people take a break from their work and go on vacations) and I haven't gotten around to tackle this. And I probably won't, looking and the rate that issues and PRs are handled here.

I have discovered something similar that might replace json-server for my project: Mockoon.

@typicode
Copy link
Owner

typicode commented Nov 3, 2022

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants