Fix issue on IsNumberString ignores maxDecimalPlaces option #508 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlapo
suggested changes
Mar 16, 2020
| @@ -3281,19 +3294,19 @@ describe("isHash", function() { | |||
| it("should not fail if validator.validate said that its valid", function(done) { | |||
| checkValidValues(new MyClass(), validValues, done); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
please remove this "empty" changes
| isNumberString(value: unknown, options?: ValidatorJS.IsNumericOptions): boolean { | ||
| return typeof value === "string" && this.validatorJs.isNumeric(value, options); | ||
| isNumberString(value: unknown, options?: IsNumberOptions): boolean { | ||
| return typeof value === "string" && this.validatorJs.isNumeric(value) && (options == null || this.isNumber(parseFloat(value), options)); |
There was a problem hiding this comment.
It is necessary && (options == null || this.isNumber(parseFloat(value), options) part? I think isNumber accept also undefined as option argument.
| @@ -530,8 +530,8 @@ export class Validator { | |||
| * Checks if the string is numeric. | |||
| * If given value is not a string, then it returns false. | |||
| */ | |||
| isNumberString(value: unknown, options?: ValidatorJS.IsNumericOptions): boolean { | |||
| return typeof value === "string" && this.validatorJs.isNumeric(value, options); | |||
| isNumberString(value: unknown, options?: IsNumberOptions): boolean { | |||
There was a problem hiding this comment.
We use ValidatorJS.* prefix everywhere. Please do not change it her.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
IsNumberStringacceptsIsNumberOptionsoptions but is NOT passing and validating against the number validator.Fix
Added the support for a number validation with
IsNumberString. The value will be also validated against providedIsNumberOptionsas a float.