Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsPort is missing validation error message #403

Closed
zavarka opened this issue Aug 19, 2019 · 3 comments
Closed

IsPort is missing validation error message #403

zavarka opened this issue Aug 19, 2019 · 3 comments

Comments

@zavarka
Copy link

zavarka commented Aug 19, 2019

No error message is provided when isPort validation fails (#282). If you could add message for IS_PORT that would be great!

class-validator/src/validation/ValidationTypes.ts

Line 113 in 35ec04d

static getMessage(type: string, isEach: boolean): string|((args: ValidationArguments) => string) {

@rubiin
Copy link
Contributor

rubiin commented Aug 19, 2019

added that in pr #404

@vlapo
Copy link
Contributor

vlapo commented Aug 19, 2019

Closed by #404

@vlapo vlapo closed this as completed Aug 19, 2019
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlapo @zavarka @rubiin