feat(eslint-plugin): add no-non-null-asserted-optional-chain #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradzacher
added
the
enhancement: new plugin rule
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
+ Coverage 95.55% 95.55% +<.01%
==========================================
Files 144 145 +1
Lines 6569 6576 +7
Branches 1878 1878
==========================================
+ Hits 6277 6284 +7
Misses 111 111
Partials 181 181
|
armano2
reviewed
Jan 18, 2020
armano2
reviewed
Jan 18, 2020
packages/eslint-plugin/tests/rules/no-non-null-asserted-optional-chain.test.ts
Show resolved
Hide resolved
armano2
approved these changes
Jan 18, 2020
mightyiam
added a commit
to mightyiam/eslint-config-love
that referenced
this pull request
Feb 4, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain typescript-eslint/typescript-eslint#1469 BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion typescript-eslint/typescript-eslint#1460 Closes #218.
mightyiam
added a commit
to mightyiam/eslint-config-love
that referenced
this pull request
Feb 11, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain typescript-eslint/typescript-eslint#1469 BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion typescript-eslint/typescript-eslint#1460 Closes #218.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1398