Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ngrx rule converters #1056

Closed
KingDarBoja opened this issue May 16, 2021 · 3 comments · Fixed by #1194
Closed

Add missing ngrx rule converters #1056

KingDarBoja opened this issue May 16, 2021 · 3 comments · Fixed by #1194
Assignees
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request

Comments

@KingDarBoja
Copy link
Collaborator

KingDarBoja commented May 16, 2021

🚀 Feature Request

Existing Behavior

There is another TSLint plugin that needs converting to the existing ESLint equivalent for the ngrx library:

We can use the migration guide provided at the eslint plugin docs.

Change Proposal

Add the missing converters. Should be easy to setup after adding #813 feature as most rules do not require configuration.

@KingDarBoja KingDarBoja added the type: enhancement New feature or request label May 16, 2021
@KingDarBoja KingDarBoja self-assigned this May 16, 2021
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send in a PR to resolve this! ✨ label Jul 4, 2021
@rafaelss95
Copy link
Contributor

I'm interested on taking this, @JoshuaKGoldberg @KingDarBoja (of course, if you haven't started working on this). Let me know if I can and another question: do you prefer a PR for each rule or can be everything in a single go?

@JoshuaKGoldberg
Copy link
Member

🎉 , absolutely, please do take it on!

Since this repository has even fairly stable lately I'll leave that up to you. In theory one PR per rule would be easier for getting them in sooner and I generally lean towards that, but if you strongly prefer one big one that's fine too.

@rafaelss95
Copy link
Contributor

Done, @JoshuaKGoldberg 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants