Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support max execution time for MySQL driver. #7638

Merged
merged 1 commit into from
May 15, 2021
Merged

Support max execution time for MySQL driver. #7638

merged 1 commit into from
May 15, 2021

Conversation

and1truong
Copy link
Contributor

@and1truong and1truong commented May 10, 2021 •
edited
Loading

Description of change

Support MAX_EXECUTION_TIME hint for MySQL driver.

Fix #7639

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@and1truong and1truong mentioned this pull request May 10, 2021
Closed
2 tasks
mrsinguyen
mrsinguyen approved these changes May 10, 2021
View reviewed changes
Copy link

@mrsinguyen mrsinguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from me

@AlexMesser AlexMesser merged commit 0564c34 into typeorm:master May 15, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

@and1truong and1truong deleted the mysql-maxExecutionTime branch May 15, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsinguyen mrsinguyen mrsinguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MAX_EXECUTION_TIMEOUT for MySQL driver
3 participants
@and1truong @AlexMesser @mrsinguyen