feat: Embedded entities with entity schema #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleerock
reviewed
Feb 12, 2022
src/metadata/types/TableTypes.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| /** | |||
| * Table type. Tables can be closure, junction,, etc. | |||
| */ | |||
| export type TableType = "regular"|"view"|"junction"|"closure"|"closure-junction"|"entity-child"; | |||
| export type TableType = "regular"|"view"|"junction"|"closure"|"closure-junction"|"entity-child"|"embedded"; | |||
There was a problem hiding this comment.
I doubt we need it. Embeds already supported and everything work correctly without this new table type. You just need properly convert entity schema definitions into metadata just like what decorator-based stuff does.
There was a problem hiding this comment.
@pleerock I did a lot of changes. Could you check again?
pnkp
force-pushed
the
feature/embedded-entities-with-entity-schema
branch
10 times, most recently
from
6a0885c
to
cc323f8
Compare
pleerock
reviewed
Feb 16, 2022
docs/separating-entity-definition.md
Outdated
|
|
||
| export const NameEntitySchema = new EntitySchema<Name>({ | ||
| name: "name", | ||
| target: Name, // target field is required for Embedded Entity! |
There was a problem hiding this comment.
It should not be required. We should be able to use entity schemas without targets for sure. Most people don't use entity schemas without classes, just with a regular types/interfaces.
pnkp
force-pushed
the
feature/embedded-entities-with-entity-schema
branch
from
cc323f8
to
fd14155
Compare
Added `embeddeds` field into EntitySchemaOptions Added transformation to MetadataArgsStorage for embedded entities Updated docs Created new tests cases for EntitySchema with Embedded Entities Changed type for field: `target` in EmbeddedMetadataArgs CLOSES: typeorm#3632
pnkp
force-pushed
the
feature/embedded-entities-with-entity-schema
branch
from
fd14155
to
a18164a
Compare
pleerock
reviewed
Feb 17, 2022
|
Think we can merge it. |
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
embeddedsfield into EntitySchemaOptionstargetin EmbeddedMetadataArgsPull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this change