DeleteResult / UpdateResult not implemented for all Drivers

[marko-asplund]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[x] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native

TypeORM version:

[ ] latest
[ ] @next
[x] 0.2.7 (or put your version here)

Steps to reproduce or a small repository showing the problem:

1. invoke Repository.delete
2. the returned DeleteResult does not include any info at all. Expecting to include the number of affected rows.

I'm having trouble with Repository.delete: the operation successfully removes the entity from the database, but DeleteResult does not contain count of entities deleted, it's just DeleteResult { raw: [] }. This occurs with v0.2.7.

Also, there doesn't appear to be a tag for version 0.2.7 on GitHub though there's a release on npmjs. Why is that?

Why doesn't DeleteResult specify a property for the number of rows affected?

[pleerock]

Also, there doesn't appear to be a tag for version 0.2.7 on GitHub though there's a release on npmjs. Why is that?

I'll fix that.

Why doesn't DeleteResult specify a property for the number of rows affected?

because it wasn't implemented. We already have this feature reported, but noone still took on its implementation. Please feel free, its an easy feature to implement.

[marko-asplund]

@pleerock Can you give a reference to an earlier report? I just tried, but was unable to find one.

[pleerock]

I could find only #1308 which is related, need to search deeper to find that one. But anyway, you don't need that issue if you want to implement it. You know what your goal, you can easily do that. But please be sure to implement it for all drivers if you are going to do it. That's easy feature to implement

[edevil]

@pleerock Currently the behavior is different between Postgres and MySQL, for example.

MySQL returns: {"raw":{"fieldCount":0,"affectedRows":0,"insertId":0,"serverStatus":34,"warningCount":0,"message":"","protocol41":true,"changedRows":0}}

Postgres returns: {"raw": []}

So in a sense it seems MySQL already has this feature implemented but not Postgres.

[thibaud-sanchez]

I have the same problem with SQLite and 0.2.8
It returns : {"raw": []}

[pleerock]

raw is just raw result returned by underlying database driver. As I pointed above we need to implement this feature request.

[HardySoftware]

MongoDb does not return anything, neither raw nor affected regardless if the record is found/deleted or not.

[akosasante]

In case it helps anyone else in the future, for postgres I ended up just using

       await this.db.createQueryBuilder()
            .delete()
            .whereInIds(id)
            .returning("id")
            .execute();

It returns a DeleteResult like: { raw: [ {id: 1} ], affected: 1 }. You could also do .returning("*") if you want the full object returned.

[varogonz95]

Is this implemented? I'm facing this issue too with sqlite3 and typeorm@^0.2.12

[dennbagas]

       await this.db.createQueryBuilder()
            .delete()
            .whereInIds(id)
            .returning("id")
            .execute();

this didn't work for me, it just returns an empty object. I use [email protected].

[liv1n9]

MongoDb does not return anything, neither raw nor affected regardless if the record is found/deleted or not.

Has it been fixed?

[VinayKrMittal]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[x] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native

TypeORM version:

[ ] latest
[ ] @next
[x] 0.2.7 (or put your version here)

Steps to reproduce or a small repository showing the problem:

1. invoke Repository.delete
2. the returned DeleteResult does not include any info at all. Expecting to include the number of affected rows.

I'm having trouble with Repository.delete: the operation successfully removes the entity from the database, but DeleteResult does not contain count of entities deleted, it's just DeleteResult { raw: [] }. This occurs with v0.2.7.

Also, there doesn't appear to be a tag for version 0.2.7 on GitHub though there's a release on npmjs. Why is that?

Why doesn't DeleteResult specify a property for the number of rows affected?

same issue for me. any solution..

[AndreySavenkov]

Same issue. Deleting record in MongoDB results an empty DeleteResult object

[danielb7390]

Trying to change from sequelize... and i hit this "bug", quite sad this issue is still open..

[TBG-FR]

@AndreySavenkov Same here. I'm curious, how did you managed that then ?

[adelsagemilang]

Is there any alternative solution for this?

Same issue. Deleting record in MongoDB results an empty DeleteResult object

[ynwd]

Same issue

sqlite

[ibraah88]

MongoDb does not return anything, neither raw nor affected regardless if the record is found/deleted or not.

Has it been fixed?

+1

[TBG-FR]

@imnotjames can you also add driver:mongodb (or should we open another issue ?)

[viniciusmolina12]

Same issue in mssql driver

[Juraj-Masiar]

This should be fixed also for the "INSERT" where Postgres returns number of inserted rows.
I'm using .onConflict('do nothing') so I now don't know if the row was inserted or not. At least here I can use .returning('id') as a workaround.

[pliniopvv]

Not fixed to SQLite3?

UpdateResult { generatedMaps: [], raw: [] }

[nebkat]

Am proposing that processing of results is moved to individual drivers as part of #7058 e666d7d.

[SalahAdDin]

Two years and same problem with Mongo: it always returns {}, it does not matter if it deletes the user or not, it does not return any error.

[Zyles]

Why is this not a priority?

[Kolobamanacas]

So, am I correct: there is no way to check whether any rows have been affected by delete method for PostgreSQL, right?

[matomesc]

@Kolobamanacas this works as expected for postgres on 0.2.32:

// Deleting one row
const result = await repo.delete(userA.id);
// Return result is
DeleteResult { raw: [], affected: 1 }

[nbaua]

No one really looking in to UpdateResult or DeleteResult for mongodb, its been a while this thread is still open..

[VictorLM]

Still getting empty result using MongoDB driver.

[imnotjames]

The logic for query results have been moved into the drivers via #7753

This means implementing it is up to the drivers.

The MongoDB driver doesn't return lots of this because it's EXTREMELY janky. It was implemented to query by not really doing things like any other driver & hacks up the whole TypeORM library to make it barely work..

Might still be able to make it sort of work, though, if the underlying module supports it.

Even then, though, it might not help much because it doesn't use the query builder and all that jazz.

[imnotjames]

This should be implemented for every driver now except for MongoDB with #7753 - to be in the next release.

[imnotjames]

Opened a PR to implement it for the mongo EntityManager because that seems to be where that logic lives..

[marcosdipaolo]

And for the rest of the drivers? sqlite here, neither DeleteResult nor UpdateResult have the right info

[imnotjames]

And for the rest of the drivers? sqlite here, neither DeleteResult nor UpdateResult have the right info

With the master branch?

[marcosdipaolo]

And for the rest of the drivers? sqlite here, neither DeleteResult nor UpdateResult have the right info

With the master branch?

"typeorm": "^0.2.34",

[imnotjames]

This code has not been released yet. We're aiming for a release this week.

We'll also be aiming to do a "bleeding edge" set of releases.

[jdeg]

I'm still having this issue in SQLite3. Any news about it?

[imnotjames]

I'm still having this issue in SQLite3. Any news about it?

Should be released at this point. If it's not working for your use case please open a new issue.

[HazemHa]

it is not solved yet
MySQL version: 8.0.27

but you can do it by yourself

async remove(id: string): Promise<DeleteResult> {
        const deletedRow = await this.nodesRepository.findOne({ uuid: id });
        const deleteResultNode = await this.nodesRepository.delete({ uuid: id })
        if (deleteResultNode.affected > 0) {
            deleteResultNode.raw.push(deletedRow)
        }

        return deleteResultNode;

    }

[DanielYoung-Till]

2024 now.

[SteTSC]

2024 now.

As noted by @DanielYoung-Till this is still not resolved in 0.3.20.

Code:

  update(id: number, myEntity: Partial<MyEntity>): Promise<MyEntity> {
    return this.repository
      .update({ id }, myEntity)
      .then((event) => {
        console.log(event);
      });

Expected:

{ generatedMaps: [], raw: [], affected: 1 }

Actual:

{ generatedMaps: [], raw: [{ id:123, ...etc }], affected: 1 }