Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink tlFatalWarningsInCi #254

Closed
armanbilge opened this issue Apr 11, 2022 · 0 comments · Fixed by #542
Closed

Rethink tlFatalWarningsInCi #254

armanbilge opened this issue Apr 11, 2022 · 0 comments · Fixed by #542
Labels
bug question
Milestone
v0.5.0

Comments

@armanbilge
Copy link
Member

armanbilge commented Apr 11, 2022 •
edited
Loading

  1. Why not just do tlFatalWarnings := false?
  2. prePR currently doesn't care about tlFatalWarnings, which causes problems like Migrate to sbt-typelevel cats#4160 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Better prePR command typelevel/sbt-typelevel
1 participant
@armanbilge