Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to raise test coverage on parameters passed to NoOpLogger #272

Closed
caoilte opened this issue Jan 21, 2020 · 2 comments · Fixed by #738
Closed

How to raise test coverage on parameters passed to NoOpLogger #272

caoilte opened this issue Jan 21, 2020 · 2 comments · Fixed by #738

Comments

@caoilte
Copy link

caoilte commented Jan 21, 2020

I'm failing to meet 100% coverage requirements in a module because the call by name string inside a log effect never gets executed. Would it be reasonable to make the no-op logger execute the passed in strings or to provide an option that allowed it?

@ChristopherDavenport
Copy link
Member

We can void that argument.

private def void(args: Any*): Unit = {
   val _ = args
   ()
}

If we put that in place would that fix your coverage issue?

@ant8e
Copy link
Contributor

ant8e commented Mar 24, 2023

I ran into the same problem today. The solution proposed by @ChristopherDavenport seems sensible. Would a PR along these lines be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants