Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Files.walk(start: Path, maxDepth: Int, followLinks: Boolean) ignores maxDepth and followLinks #3412

Closed
sven42 opened this issue Mar 23, 2024 · 1 comment · Fixed by #3413
Labels

Comments

@sven42
Copy link

sven42 commented Mar 23, 2024

Thanks a lot for your fix of #3329

However, I found that the current implementation in v3.10.0 of the now deprecated Files.walk() ignores some of its parameters.

  def walk(start: Path, maxDepth: Int, followLinks: Boolean): Stream[F, Path] =
    walk(start, WalkOptions.Default)

should be implemented like this:

    walk(start, WalkOptions.Default.withMaxDepth(maxDepth).withFollowLinks(followLinks))
@sven42 sven42 added the bug label Mar 23, 2024
@mpilquist
Copy link
Member

Ouch, thanks for reporting. Want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants