Add 2.13.0-M3 build #2173
Add 2.13.0-M3 build #2173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2173 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 328 328
Lines 5548 5548
Branches 213 213
=======================================
Hits 5252 5252
Misses 296 296Continue to review full report at Codecov.
|
|
+1 on green |
|
blocked by scoverage/scalac-scoverage-plugin#215 now. |
|
might need to bump scalajs to 0.6.22 as well. |
|
Did you really mean #215
On Wed, Feb 21, 2018 at 17:07 Kai(luo) Wang ***@***.***> wrote:
might need to bump scalajs to 0.6.22 as well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2173 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEJdtQnqRJ1roBmqjaWdAV-O96T-kbIks5tXNn0gaJpZM4SMF6N>
.
--
P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin
|
|
@johnynek I mistyped. sorry about the noise. anyway this is still blocked by scalac-scoverage-plugin |
|
scalac-scoverage-plugin has now been published for 2.13.0-M3 and yes, you'll definitely need to bump Scala.js to 0.6.22 |
LukaJCB
force-pushed
the
13-m3
branch
3 times, most recently
from
252d909 to
5ae48f9
Compare
|
We're still blocked by catalysts and export-hook |
|
export-hook now published for 2.13.0-M3. |
Looking now.... |
|
cc'ing from gitter chat
|
|
Additionally, last year when I compiled for cats with 2.13.0-M3 there were a few code changes required for simulacrum, that were not too obvious. And for scalatest, a milestone release is required. It might be easier if I just push an new PR in the next few days. Any objections if I did that? Obviously we can keep this open in the meantime |
|
I'll try to get tut working for 2.13-M2+ later this week. It's going to be terrible. I can feel it. |
|
let us know if you get stuck, we'll help. |
|
tut 0.6.3-M5 appears to work with 2.13.0-M3 … I'll do a final in a day or two if nothing comes up. So @BennyHill you may or may not want to wait. |
|
@tpolecat Awesome! Let's see how far I can get with this 👍 |
|
The background work for this is effectively done (cats PR, discipline PR, new tut, new microsites), but the build is faiing due to, I beileve, a 2.13.0-M3 regression. See https://gist.github.com/BennyHill/6e4f698fe7f85309caeb8fffdf474fd0 and scalaz/scalaz#1629 |
|
Gitter ref https://gitter.im/typelevel/cats-dev?at=5a945c4c8f1c77ef3a5ac263 onwards |
|
Suggestion:
That way we get the newer versions of these libs/plugins, regardless of any other work we do for 2.13 However, catalysts changes for 2.13.0-M3 are done typelevel/catalysts#16 so tomorrow/Friday I will release and also PR the newer changes specific for cats The changes are actually minimal, and the build will fail because of scala issues. This way, it's easier for others to see the changes and, if they are not fixed for cats 1.1, at least we get your upgrades from above in, |
|
@BennyHill @kailuowang @SethTisue Any idea on the current status of this? Is it actually a regression in scalac? And if so, will it get fixed in M4? |
|
@djspiewak @BennyHill did a lot of work on this one, which is merged in #2203. The build fails due to scala/bug#10706, which seems to be fixed and scheduled to release in M4. |
|
Should this PR be closed now #2203 is merged? |
Should fix #1648