Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added distributeIdentityLaw #2097

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

kailuowang
Copy link
Contributor

No description provided.

@kailuowang
Copy link
Contributor Author

@coltfred WDYT?

@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #2097 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +<.01%     
==========================================
  Files         322      322              
  Lines        5449     5451       +2     
  Branches      215      215              
==========================================
+ Hits         5158     5160       +2     
  Misses        291      291
Impacted Files Coverage Δ
...ws/src/main/scala/cats/laws/DistributiveLaws.scala 100% <100%> (ø) ⬆️
...scala/cats/laws/discipline/DistributiveTests.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91e9bb...e14f8d8. Read the comment docs.

@coltfred
Copy link
Contributor

@kailuowang I think that looks reasonable to me. We could remove cosequenceIdentity since cosequence is just distribute(identity). Maybe it's fine to leave it as it ensures they're consistent. Sorry I didn't add this in the first place.

@kailuowang
Copy link
Contributor Author

@coltfred no worries.
I thought about removing cosequenceIdentity, but as you suggested it's verifying the consistency between the two.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ceedubs ceedubs merged commit 275f723 into typelevel:master Dec 13, 2017
@kailuowang kailuowang deleted the add-distributive-laws branch December 13, 2017 14:59
@kailuowang kailuowang added this to the 1.0.0 milestone Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants