-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NaturalTransformation to FunctionK. #1072
Merged
ceedubs
merged 1 commit into
typelevel:master
from
peterneyens:rename-natural-transformation-functionk
May 31, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package cats | ||
package arrow | ||
|
||
import cats.data.{Xor, Coproduct} | ||
|
||
trait FunctionK[F[_], G[_]] extends Serializable { self => | ||
def apply[A](fa: F[A]): G[A] | ||
|
||
def compose[E[_]](f: FunctionK[E, F]): FunctionK[E, G] = | ||
new FunctionK[E, G] { | ||
def apply[A](fa: E[A]): G[A] = self.apply(f(fa)) | ||
} | ||
|
||
def andThen[H[_]](f: FunctionK[G, H]): FunctionK[F, H] = | ||
f.compose(self) | ||
|
||
def or[H[_]](h: FunctionK[H,G]): FunctionK[Coproduct[F, H, ?], G] = | ||
new FunctionK[Coproduct[F, H, ?], G] { | ||
def apply[A](fa: Coproduct[F, H, A]): G[A] = fa.run match { | ||
case Xor.Left(ff) => self(ff) | ||
case Xor.Right(gg) => h(gg) | ||
} | ||
} | ||
} | ||
|
||
object FunctionK { | ||
def id[F[_]]: FunctionK[F, F] = | ||
new FunctionK[F, F] { | ||
def apply[A](fa: F[A]): F[A] = fa | ||
} | ||
} |
31 changes: 0 additions & 31 deletions
31
core/src/main/scala/cats/arrow/NaturalTransformation.scala
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could then be something like :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that we can describe the type
FunctionK
as a natural transformation. So, when we would put the term in backticks (i.e. code) we'd sayFunctionK
but otherwise we'd say transformation or natural transformation. Does this make sense?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does make sense, yes. It felt weird to use
FunctionK
in the documentation, that's why I left the documentation itself untouched.