Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More binary compatibility breakage #3202

Closed
travisbrown opened this issue Dec 10, 2019 · 2 comments · Fixed by #3203
Closed

More binary compatibility breakage #3202

travisbrown opened this issue Dec 10, 2019 · 2 comments · Fixed by #3203

Comments

@travisbrown
Copy link
Contributor

Compile this with 2.0.0:

object Test {
  val instances = new cats.instances.AllInstancesBinCompat6 {}
  def main(args: Array[String]): Unit = println(
    instances.catsKernelStdHashForSortedSet(
      cats.kernel.instances.int.catsKernelStdOrderForInt,
      cats.kernel.instances.int.catsKernelStdOrderForInt
    )
  )
}

Then run it with 2.1.0-RC1 or RC2, and you get this:

Exception in thread "main" java.lang.NoSuchMethodError: cats.instances.SortedSetInstancesBinCompat1.catsKernelStdHashForSortedSet$(Lcats/instances/SortedSetInstancesBinCompat1;Lcats/kernel/Order;Lcats/kernel/Hash;)Lcats/kernel/Hash;
        at Test$$anon$1.catsKernelStdHashForSortedSet(Test.scala:2)
        at Test$.main(Test.scala:6)
        at Test.main(Test.scala)
        ...

This is the same basic issue as #3163 but my original MiMa fix didn't catch it. Working on a PR now.

@dwijnand
Copy link
Contributor

but my original MiMa fix didn't catch it

Could you share what other changes were needed? I don't see anything more recent in https://github.com/travisbrown/mima/commits/topic/cats-3162-check.

@travisbrown
Copy link
Contributor Author

@dwijnand The version in that branch is what caught these—I'd been through a few iterations of filtering out synthetics, etc. before then and I must not have tried the final version on Cats, just on my test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants