From 8341a4ee3a57f2eadff91af15173caeb2a53f635 Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Mon, 8 Jan 2024 21:47:05 +0000 Subject: [PATCH 1/2] Remove unneeded `notifyParked` when worker transitions to blocking --- core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala b/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala index 849e71a2d4..e731f11827 100644 --- a/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala +++ b/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala @@ -800,8 +800,6 @@ private final class WorkerThread( override def blockOn[T](thunk: => T)(implicit permission: CanAwait): T = { val rnd = random - pool.notifyParked(rnd) - if (blocking) { // This `WorkerThread` is already inside an enclosing blocking region. // There is no need to spawn another `WorkerThread`. Instead, directly From 05145d993f17c66f561ee9270374fe183eb550e1 Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Mon, 8 Jan 2024 14:05:15 -0800 Subject: [PATCH 2/2] `random` is no longer used --- core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala b/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala index e731f11827..4c72714afb 100644 --- a/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala +++ b/core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala @@ -798,8 +798,6 @@ private final class WorkerThread( * code path can be exercised is through `IO.delay`, which already handles exceptions. */ override def blockOn[T](thunk: => T)(implicit permission: CanAwait): T = { - val rnd = random - if (blocking) { // This `WorkerThread` is already inside an enclosing blocking region. // There is no need to spawn another `WorkerThread`. Instead, directly