Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AndThen, as StateT was fixed in Cats 1.1 #171

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

alexandru
Copy link
Member

@alexandru alexandru commented Mar 23, 2018

I fixed IndexedStateT in Cats 1.1 to be stack safe on left-associated binds, or otherwise it was failing the laws of Sync. See: typelevel/cats#2187

But before that we merged that same fix in cats-effect as well, to make a 0.10 release possible. Granted we could have used better synchronization with the Cats 1.1 release, but doesn't matter much.

So now I'm removing my fixes on Sync[StateT[F, S, ?]] from cats-effect as these are no longer necessary, being moved in Cats proper.

Spring cleanup. Although you should see Bucharest right now, it's anything but Spring here 🌨❄️⛄️

@alexandru alexandru added this to the 1.0.0-RC milestone Mar 23, 2018
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #171 into master will decrease coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #171     +/-   ##
=========================================
- Coverage   90.01%   89.52%   -0.5%     
=========================================
  Files          47       46      -1     
  Lines        1002      964     -38     
  Branches       78       74      -4     
=========================================
- Hits          902      863     -39     
- Misses        100      101      +1

@alexandru alexandru merged commit e46d4b9 into typelevel:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants