Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: epoch included in each block #194

Closed
CyberCyclone opened this issue Mar 11, 2022 · 2 comments · Fixed by #195
Closed

feat: epoch included in each block #194

CyberCyclone opened this issue Mar 11, 2022 · 2 comments · Fixed by #195
Assignees
@rvcas
Labels
enhancement New feature or request
Milestone
v1.3

Comments

@CyberCyclone
Copy link

CyberCyclone commented Mar 11, 2022 •
edited
Loading

It would be good to include epoch data with each block. E.g:

Add epoch and slot_in_epoch fields to the block event.

{
    "era": "Byron",
    "body_size": 633,
    "issuer_vkey": "9a6fa343c8c6c36de1a3556feb411bfdf8708d5af88de8626d0fc6bfa4eebb6d99ab83d90d66531ad9122d3f9cb4bc9d05b26448672532a68da796f9328431fd",
    "tx_count": 0,
    "slot": 7867,
    "hash": "b2a229030ec5ca41fe37b0a92eda80e0a47726a4d768fa52d34419ae2a8c3b5d",
    "number": 7868,
    "previous_hash": "c64b0b0ded5cd12fdaa328b9a7df23303ace3155fe5b34c891b7c92e6a8fdfe2",
    "epoch": 1,
    "slot_in_epoch": 7867 
}
@scarmuega
Copy link
Member

I agree. We'll include it in the next release.

@scarmuega scarmuega added the enhancement New feature or request label Mar 11, 2022
@scarmuega scarmuega added this to the v1.3 milestone Mar 11, 2022
@scarmuega scarmuega moved this to Refinement in Oura Development Mar 11, 2022
@scarmuega scarmuega moved this from Refinement to Todo in Oura Development Mar 11, 2022
@rvcas rvcas self-assigned this Mar 11, 2022
@rvcas rvcas mentioned this issue Mar 11, 2022
Merged
@scarmuega scarmuega moved this from Todo to In Progress in Oura Development Mar 25, 2022
Repository owner moved this from In Progress to Done in Oura Development Mar 25, 2022
@scarmuega
Copy link
Member

This feature will go out in v1.3. New values are: epoch and epoch_slot, present in each Block event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvcas rvcas

Labels
enhancement New feature or request
Projects
No open projects
Oura Development
Status: Done
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

feat(BlockRecord): add new fields txpipe/oura
3 participants
@scarmuega @CyberCyclone @rvcas