Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy? (if so, strength?) #48

Closed
tony opened this issue Sep 7, 2022 · 3 comments · Fixed by #50
Closed

mypy? (if so, strength?) #48

tony opened this issue Sep 7, 2022 · 3 comments · Fixed by #50

Comments

@tony
Copy link
Contributor

tony commented Sep 7, 2022

Example of a strictly typed module: https://github.com/git-pull/gp-libs/blob/v0.0.1a9/src/pytest_doctest_docutils.py

Thoughts? Have you used mypy yet?

Basic mypy will pass out of the box on the project

@tony tony changed the title mypy? Strength? mypy? (if so, strength?) Sep 7, 2022
@tony tony mentioned this issue Sep 7, 2022
@twmr
Copy link
Owner

twmr commented Sep 7, 2022

I'm in favor of using mypy, because I think it makes the code more readable. Go ahead and add type annotations if you want ;)

@twmr
Copy link
Owner

twmr commented Sep 7, 2022

I don't yet have a mypy config that we could use. Maybe we could re-use the one from pytest or maybe we are satisfied with the stock config, I don't have a stance on that.

@tony
Copy link
Contributor Author

tony commented Sep 8, 2022

#50 is up

#47 (flake8 plugins) are up

@twmr twmr closed this as completed in #50 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants