This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable Scala 2.11 SBT builds for util-eval, ostrich, and finagle-ostr…
…ich4 Problem We want to publish 2.11 releases of Finagle subprojects that depend on Ostrich, which we have not previously built for 2.11 (because it has specs tests, and because it depends on scala-json and util-eval, neither of which previously worked on 2.11). Solution util-eval previously didn't work on 2.11 because `scala.ScalaObject` has been removed since 2.10. This is fixed here. The bulk of this commit is Rodrigo Lazoti's migration of Ostrich's tests from specs to ScalaTest (I'm not using his pull request since the PR also replaces scala-json with Jackson, which we don't want to do at this time to avoid breaking public APIs). This commit also reinstates util-eval and the Finagle subprojects that depend on Ostrich in their projects' cross-builds. Result util-eval, ostrich, finagle-ostrich4, finagle-example, and finagle-stress all build and pass tests on 2.11 (from SBT) for the first time. RB_ID=534127
- Loading branch information
1 parent
6197982
commit a202800
Showing
36 changed files
with
2,297 additions
and
2,123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,18 @@ | ||
language: scala | ||
|
||
scala: | ||
- 2.9.2 | ||
script: "./sbt test" | ||
- 2.10.4 | ||
- 2.11.4 | ||
|
||
jdk: | ||
- oraclejdk7 | ||
# Note: not currently testing on JDK 8 internally | ||
- oraclejdk8 | ||
- openjdk7 | ||
|
||
before_script: | ||
# default $SBT_OPTS is irrelevant to sbt lancher | ||
- unset SBT_OPTS | ||
|
||
script: | ||
- ./sbt ++$TRAVIS_SCALA_VERSION test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
src/test/scala/com/twitter/ostrich/ConfiguredSpecification.scala
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.